LGTM.
On ia32/x64, some places we move from stack memory to registers and then
push,
and other places we push stack memory operands. We should probably be
consistent one way or the other.
http://codereview.chromium.org/583008/diff/1/3
File src/ic.cc (right):
http://codereview.chromium.org/583008/diff/1/3#newcode1323
src/ic.cc:1323: void LoadIC::GenerateInitialize(MacroAssembler* masm) {
I think it's OK to put all these in the ic.h file.
http://codereview.chromium.org/583008
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev