https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode40
src/compiler/interpreter-assembler.h:40: Node* IncomingAccumulator();
The distinction between "incoming" accumulator and the "outgoing"
accumulator is somewhat confusing. E.g. it really only makes sense from
the perspective of the user of the assembler. Maybe just
"GetAccumulator() and SetAccumulator()", since the assembler is just
holding the current state?
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode71
src/compiler/interpreter-assembler.h:71: Node* RegisterFilePointer();
Can we name this RegisterFileRawPointer() and the one below
BytecodeArrayTaggedPointer() to keep them straight?
https://codereview.chromium.org/1289863003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
