On 2015/08/14 13:09:14, Hannes Payer wrote:
On 2015/08/14 12:44:36, Michael Lippautz wrote:
> lgtm, I like it. Let's wait for Hannes.
>
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
> File src/heap/mark-compact-inl.h (right):
>
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h#newcode26
> src/heap/mark-compact-inl.h:26: void
MarkCompactCollector::PushBlack(HeapObject*
> obj) {
> Suggestion: We could return the status of the operation here, turning
most
> callers of this function into
> if (!PushBlack(object)) return;
We could also wrap the unshift sites. Wdyt?
I started out with wrapping UnshiftBlack as well, but it would need to be
called
from IncrementalMarkingMarkingVisitor which is not a fried of
MarkCompactCollector. And making that wrapper public rubs me the wrong way.
Let
me know if you still want me to wrap it and make those two classes friends.
https://codereview.chromium.org/1293773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
