On 2015/08/15 01:06:15, adamk wrote:
lgtm

https://codereview.chromium.org/1292393002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1292393002/diff/1/src/preparser.h#newcode3982
src/preparser.h:3982: : this->NewThrowSyntaxError(message, pos);
On 2015/08/14 17:06:17, caitp wrote:
> I'm not sure if this distinction is necessary or good here --- getting rid
of
> this does make the patch a lot smaller.
>
> SpiderMonkey does not make the distinction, at any rate.

Seems fine to me, and also makes sense tonot throw a SyntaxError at runtime...

Thanks for the look

https://codereview.chromium.org/1292393002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to