Reviewers: cbruni,
Message:
If you want to land a CL like this, please go ahead. This was not ready
yet. I'd
wanna add the following things:
- Make coverage=1 imply clang=0
- Properly unset any -O1/2/3 cflags - I think right now we end up with two
flags
set, e.g. "-O3 -O0", which is a bit messy
- Figure out if we need to unset any other optimization options
- Make sure that the host_clang option is not in the way
If nobody else picks it up, I'll work on it when I'm back from my leave...
Description:
Support code coverage.
COMMIT=false
Please review this at https://codereview.chromium.org/1297843003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -0 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
2bdd39dc4fc54d53f3d0d1d63914c63f7883dd5e..85a555c47fdc3c819df447eae96e19c861a4d6ed
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -39,6 +39,7 @@
# - track the chain of stores leading from allocation site to use site.
'msan_track_origins%': 2,
'visibility%': 'hidden',
+ 'coverage%': 0,
'v8_enable_backtrace%': 0,
'v8_enable_i18n_support%': 1,
'v8_deprecation_warnings': 1,
@@ -615,6 +616,10 @@
[ 'component=="shared_library"', {
'cflags': [ '-fPIC', ],
}],
+ [ 'coverage==1', {
+ 'cflags': [ '-fprofile-arcs', '-ftest-coverage', '-O0'],
+ 'ldflags': [ '-fprofile-arcs'],
+ }],
],
},
}],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
