LGTM modulo one comment about evaluation order.
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.h#newcode39
src/compiler/interpreter-assembler.h:39: // Returns the Imm8 immediate
for bytecode operand |index| in the current
nit: Comment seems to be outdated, no index is passed in.
https://codereview.chromium.org/1294793002/diff/20001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1294793002/diff/20001/src/interpreter/interpreter.cc#newcode149
src/interpreter/interpreter.cc:149: __ StoreRegister(__
GetAccumulator(), __ BytecodeOperandReg(0));
This pattern looks dangerous, note that C++ does not specify the
evaluation order or the argument, so here either "GetAccumulator" or
"BytecodeOperandReg" could be assembled first into the bytecode stream.
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
