I'm pretty sure I've already reviewed this as part of http://codereview.chromium.org/573009
Is there any reason for me to take a new look at it? (You don't seem to have fixed the indentation I flagged in that review yet.) On Tue, Feb 9, 2010 at 11:28 AM, <[email protected]> wrote: > Reviewers: Kevin Millikin, > > Message: > A tiny review for you. > > Description: > Change GenerateLoadStringLength to have two scratch registers on all > platforms. > This is needed so that the LoadIC can pass the receiver in a register, and > not > have it overwritten, and also simplifies the code. > > Please review this at http://codereview.chromium.org/596011 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/ic-arm.cc > M src/arm/stub-cache-arm.cc > M src/ia32/ic-ia32.cc > M src/ia32/stub-cache-ia32.cc > M src/stub-cache.h > M src/x64/ic-x64.cc > M src/x64/stub-cache-x64.cc > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
