Reviewers: Michael Lippautz,
Description:
Remove grab-bag includes of v8.h from heap.
[email protected]
Please review this at https://codereview.chromium.org/1291833003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -17 lines):
M src/heap/gc-idle-time-handler.cc
M src/heap/gc-tracer.h
M src/heap/gc-tracer.cc
M src/heap/heap.cc
M src/heap/identity-map.h
M src/heap/identity-map.cc
M src/heap/incremental-marking.h
M src/heap/incremental-marking.cc
M src/heap/mark-compact.cc
M src/heap/mark-compact-inl.h
M src/heap/objects-visiting.h
M src/heap/objects-visiting.cc
M src/heap/spaces.cc
M src/heap/store-buffer.cc
M src/heap/store-buffer-inl.h
Index: src/heap/gc-idle-time-handler.cc
diff --git a/src/heap/gc-idle-time-handler.cc
b/src/heap/gc-idle-time-handler.cc
index
e9324de4672738681e5119aad59266081f101102..096412d578bc6b33693fb9d55aeafeb50f5d416b
100644
--- a/src/heap/gc-idle-time-handler.cc
+++ b/src/heap/gc-idle-time-handler.cc
@@ -2,8 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/flags.h"
#include "src/heap/gc-idle-time-handler.h"
+
+#include "src/flags.h"
#include "src/heap/gc-tracer.h"
#include "src/utils.h"
Index: src/heap/gc-tracer.cc
diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc
index
7dbe5fc2ee0f142a2ae88d636a1cb3bb1b3a2803..3b8e24b4743980f58d14f88c79eea07b5fe57c86
100644
--- a/src/heap/gc-tracer.cc
+++ b/src/heap/gc-tracer.cc
@@ -2,10 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#include "src/heap/gc-tracer.h"
+#include "src/counters.h"
+#include "src/heap/heap.h"
+#include "src/isolate.h"
+#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle
breaker!
+
namespace v8 {
namespace internal {
Index: src/heap/gc-tracer.h
diff --git a/src/heap/gc-tracer.h b/src/heap/gc-tracer.h
index
9f383bf890f5ca30eb8568521260461806cc80dd..e4751c84184ece1612a29e154a2e7bb457439d20
100644
--- a/src/heap/gc-tracer.h
+++ b/src/heap/gc-tracer.h
@@ -6,6 +6,7 @@
#define V8_HEAP_GC_TRACER_H_
#include "src/base/platform/platform.h"
+#include "src/globals.h"
namespace v8 {
namespace internal {
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
0fd15cff096ab1ee2d107f0d31cc53f1a5de4bba..3f6b9d64a5137e8c963560e9b7823cf565377b24
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
+#include "src/heap/heap.h"
#include "src/accessors.h"
#include "src/api.h"
@@ -33,6 +33,7 @@
#include "src/snapshot/serialize.h"
#include "src/snapshot/snapshot.h"
#include "src/utils.h"
+#include "src/v8.h"
#include "src/v8threads.h"
#include "src/vm-state-inl.h"
Index: src/heap/identity-map.cc
diff --git a/src/heap/identity-map.cc b/src/heap/identity-map.cc
index
a93f607ee7797e9191a2083ad71f16c543ee48f4..e4ce4e562c9a158c75e451a2b6a6f0b306ce1331
100644
--- a/src/heap/identity-map.cc
+++ b/src/heap/identity-map.cc
@@ -2,10 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
+#include "src/heap/identity-map.h"
#include "src/heap/heap.h"
-#include "src/heap/identity-map.h"
+#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle
breaker!
+#include "src/zone-containers.h"
namespace v8 {
namespace internal {
Index: src/heap/identity-map.h
diff --git a/src/heap/identity-map.h b/src/heap/identity-map.h
index
5c754bccda74a90e10330d06d5d08f07576e66de..672ca5a52a7e292a08cc8de8dcd860b9355ba605
100644
--- a/src/heap/identity-map.h
+++ b/src/heap/identity-map.h
@@ -10,7 +10,9 @@
namespace v8 {
namespace internal {
+// Forward declarations.
class Heap;
+class Zone;
// Base class of identity maps contains shared code for all template
// instantions.
Index: src/heap/incremental-marking.cc
diff --git a/src/heap/incremental-marking.cc
b/src/heap/incremental-marking.cc
index
db19165f0a310eb0dec219df1226b8333c17e96e..4440d7f9eb27331c020dad2cf61e5b9615a07a72
100644
--- a/src/heap/incremental-marking.cc
+++ b/src/heap/incremental-marking.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#include "src/heap/incremental-marking.h"
#include "src/code-stubs.h"
Index: src/heap/incremental-marking.h
diff --git a/src/heap/incremental-marking.h b/src/heap/incremental-marking.h
index
ac1d532a8f2f1d4a5859abe9e44494071ca47a01..4f2bfc29b59f8bdeafb9fd4c6e9f5a7321124501
100644
--- a/src/heap/incremental-marking.h
+++ b/src/heap/incremental-marking.h
@@ -5,7 +5,6 @@
#ifndef V8_HEAP_INCREMENTAL_MARKING_H_
#define V8_HEAP_INCREMENTAL_MARKING_H_
-
#include "src/execution.h"
#include "src/heap/mark-compact.h"
#include "src/objects.h"
Index: src/heap/mark-compact-inl.h
diff --git a/src/heap/mark-compact-inl.h b/src/heap/mark-compact-inl.h
index
d38e31e55602c14a874814ca5605facc46b61e43..b837b2884ed3db85a63dd5591cd8c63980534a22
100644
--- a/src/heap/mark-compact-inl.h
+++ b/src/heap/mark-compact-inl.h
@@ -8,7 +8,6 @@
#include "src/heap/mark-compact.h"
#include "src/isolate.h"
-
namespace v8 {
namespace internal {
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index
e34dbfd2337cc0bec932e2729d51ae1aeb5d1787..d7bbd0dd1f8917860f1ce020edf78cc645ec3104
100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
+#include "src/heap/mark-compact.h"
#include "src/base/atomicops.h"
#include "src/base/bits.h"
@@ -15,7 +15,6 @@
#include "src/gdb-jit.h"
#include "src/global-handles.h"
#include "src/heap/incremental-marking.h"
-#include "src/heap/mark-compact.h"
#include "src/heap/mark-compact-inl.h"
#include "src/heap/objects-visiting.h"
#include "src/heap/objects-visiting-inl.h"
@@ -23,6 +22,7 @@
#include "src/heap-profiler.h"
#include "src/ic/ic.h"
#include "src/ic/stub-cache.h"
+#include "src/v8.h"
namespace v8 {
namespace internal {
Index: src/heap/objects-visiting.cc
diff --git a/src/heap/objects-visiting.cc b/src/heap/objects-visiting.cc
index
0c5a0544a06f25bc1e8ed13bdac069522c10472c..d29b99eb0572f57136486777d84167a95bfbbfae
100644
--- a/src/heap/objects-visiting.cc
+++ b/src/heap/objects-visiting.cc
@@ -2,10 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
+#include "src/heap/objects-visiting.h"
#include "src/heap/mark-compact-inl.h"
-#include "src/heap/objects-visiting.h"
#include "src/heap/objects-visiting-inl.h"
namespace v8 {
Index: src/heap/objects-visiting.h
diff --git a/src/heap/objects-visiting.h b/src/heap/objects-visiting.h
index
953d89681bb3ddbd62b5a6aec68d92c5d6bdda96..03dcf757f32b2ce5f616f678afc1b4d07b37cc2b
100644
--- a/src/heap/objects-visiting.h
+++ b/src/heap/objects-visiting.h
@@ -6,6 +6,7 @@
#define V8_OBJECTS_VISITING_H_
#include "src/allocation.h"
+#include "src/heap/spaces.h"
#include "src/layout-descriptor.h"
// This file provides base classes and auxiliary methods for defining
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index
0d1c592ef400c26f70d877ac84e5b7faa4207b17..6e487a14bbc23abc993f59bacffe81e483244e47
100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
+#include "src/heap/spaces.h"
#include "src/base/bits.h"
#include "src/base/platform/platform.h"
Index: src/heap/store-buffer-inl.h
diff --git a/src/heap/store-buffer-inl.h b/src/heap/store-buffer-inl.h
index
30663752895d0dd7a2bd5f02a6defd162e1c654f..f168fe0a59a0dc03eedaf05357f870340e82a9b9
100644
--- a/src/heap/store-buffer-inl.h
+++ b/src/heap/store-buffer-inl.h
@@ -5,6 +5,7 @@
#ifndef V8_STORE_BUFFER_INL_H_
#define V8_STORE_BUFFER_INL_H_
+#include "src/heap/heap.h"
#include "src/heap/store-buffer.h"
namespace v8 {
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index
e6430d5a2ab3b7156234dd3673b61e6fcff6fc78..97dcf1bf19e8e5f14faea30a31c9ccd037b0dcc8
100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -2,12 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <algorithm>
+#include "src/heap/store-buffer.h"
-#include "src/v8.h"
+#include <algorithm>
#include "src/counters.h"
#include "src/heap/store-buffer-inl.h"
+#include "src/v8.h"
namespace v8 {
namespace internal {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
