LGTM, but can be simplified.
http://codereview.chromium.org/597006/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/597006/diff/1/2#newcode253 src/ia32/stub-cache-ia32.cc:253: __ mov(receiver, scratch2); Why not: __ mov(eax, FieldOperand(scratch2, String::kLengthOffset)); __ jmp(&tag_length); and label the SmiTag(eax) with tag_length instead of using load_length? (Or, just duplicate the tag and return). http://codereview.chromium.org/597006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
