I ran Octane locally three times with and without this patch. I measured a
2.3%
regression caused by the patch in CodeLoad. Where do we go from here? I am
having trouble figuring out a clean strategy for avoiding the conditional by
pushing back all the way into the stream, though I can imagine some messy
ways.
How bad would a regression of this magnitude be?
https://codereview.chromium.org/1295883002/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1295883002/diff/60001/src/preparser.h#newcode3744
src/preparser.h:3744: bool ParserBase<Traits>::IsLetKeyword() {
On 2015/08/15 at 00:28:31, adamk wrote:
How about "IsNextLetKeyword()"? I think that makes it clearer what
this is operating on.
Done
https://codereview.chromium.org/1295883002/diff/60001/src/preparser.h#newcode3749
src/preparser.h:3749: Token::Value uber_next = PeekAhead();
On 2015/08/15 at 00:28:31, adamk wrote:
next_next, maybe? See later comment.
Done
https://codereview.chromium.org/1295883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
