LGTM.
http://codereview.chromium.org/597006/diff/4008/3009 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/597006/diff/4008/3009#newcode224 src/arm/stub-cache-arm.cc:224: Label check_string, check_wrapper; check_string is a dead label? http://codereview.chromium.org/597006/diff/4008/3009#newcode237 src/arm/stub-cache-arm.cc:237: // If arguments to LoadIC are passed in registers, receiver must not be Reword this comment or just get rid of it. http://codereview.chromium.org/597006/diff/4008/3009#newcode245 src/arm/stub-cache-arm.cc:245: // Check if the object is a string. No need for comment. http://codereview.chromium.org/597006/diff/4008/3009#newcode247 src/arm/stub-cache-arm.cc:247: // Load length directly from the string. No need for comment. http://codereview.chromium.org/597006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
