Reviewers: Michael Achenbach (OOO),
Message:
I tested this with:
tools/run-tests.py --buildbot --outdir out --arch x64 --mode Debug
--isolates
mjsunit/regress/regress-4279 --stress-only --random-seed-stress-count=10000
Description:
[d8] Fix flakiness when calling quit() with isolates
Don't use exit(), use Shell::Exit() (which calls _exit() instead). This
won't
run C++ static destructors, atexit() functions, etc., which can occasionally
cause flaky failures.
BUG=v8:4279
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/1294913005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
d1eb9592777b3cfe2270df001c36db49885447c5..524051921b0c94af83d3a74dac77482dedbcdbcd
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -814,7 +814,7 @@ void
Shell::QuitOnce(v8::FunctionCallbackInfo<v8::Value>* args) {
CleanupWorkers();
#endif // !V8_SHARED
OnExit(args->GetIsolate());
- exit(exit_code);
+ Exit(exit_code);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
