https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#oldcode287
src/heap/mark-compact.cc:287: void
MarkCompactCollector::ClearInvalidSlotsBufferEntries(PagedSpace* space)
{
On 2015/08/18 07:05:01, Michael Lippautz wrote:
Should be dead code now?
Done.
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#newcode299
src/heap/mark-compact.cc:299: int npages =
evacuation_candidates_.length();
On 2015/08/18 07:05:01, Michael Lippautz wrote:
nit: num_pages
Done.
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#newcode302
src/heap/mark-compact.cc:302: SlotsBuffer::RemoveInvalidSlots(heap_,
p->slots_buffer());
On 2015/08/18 07:05:01, Michael Lippautz wrote:
Just a comment: Ideally we want to remove the static methods and end
up at
page->RemoveInvalidSlots();
?
Page cannot now about the filtering rules, that would be the wrong
abstraction. An option would be to make it part of MarkCompactCollector.
https://codereview.chromium.org/1299623003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
