Reviewers: Hannes Payer, haraken, vogelheim,
Message:
{GCPrologueCallback} and {GCEpilogueCallback} and their corresponding
{CallbackPair}s are exactly the same, respectively. We never differentiate
between them. From V8's perspective it's a callback and all that matters is
the
signature. IMHO we should unify them, wdyt?
https://codereview.chromium.org/1298113003/diff/40001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/1298113003/diff/40001/src/global-handles.cc#newcode848
src/global-handles.cc:848: isolate()->heap()->CallGCPrologueCallbacks(
I am not particularly happy with this dependency. Suggestions?
Description:
[api] Fix external GC callbacks.
* Add types to properly report what has been executed in the GC
* Unify GCPrologueCallback and GCEpilogueCallback into GCCallback
* Report processing of second round weak handels, either synchronously or
asynchronously
BUG=chromium:521946
LOG=N
Please review this at https://codereview.chromium.org/1298113003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+57, -52 lines):
M include/v8.h
M src/api.cc
M src/global-handles.cc
M src/heap/heap.h
M src/heap/heap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
