lgtm (Looks good, API-wise.)
Please note that we're presently in API freeze until the M46 branch is cut.
That
means your change - which is 100% backwards compatible - is fine, but a
*use* of
this change by an embedder - which I'd assume is the next step - is not. The
reason is that in the release phase Chrome releng has oftentimes found it
necessary to rollback to an older version of V8; and once a Blink-side
change
would make use of the new typedefs or enums that would no longer be
possible.
So if you are planning a matching Blink change, please do hold off with that
change until after the branch, next week.
https://codereview.chromium.org/1298113003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
