Please see my suggestion: https://codereview.chromium.org/1303463002/
https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives-common.cc
File src/snapshot/natives-common.cc (right):
https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives-common.cc#newcode15
src/snapshot/natives-common.cc:15: FixedArray*
NativesCollectionBase<type>::GetSourceCache(Heap* heap) {
First trying to templatize NativesCollection and then having a switch
over the template parameter doesn't make much sense to me. What was
wrong to patch set #2 without dropping the explicit declarations from
natives-external.cc?
https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives.h
File src/snapshot/natives.h (right):
https://codereview.chromium.org/1292533005/diff/40001/src/snapshot/natives.h#newcode9
src/snapshot/natives.h:9: #include "src/heap/heap-inl.h"
Please also actually remove the includes.
https://codereview.chromium.org/1292533005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
