Reviewers: ,
Message:
This is still a work in progress. It was an attempt to put the logic for
this
into a more singular place. It didn't entirely work out that way.
My findings:
- The tracking of valid assignment targets from the original CL works a lot
better than this (but is much more spread out)
- The expression "flavor" idea may make it possible to support
CoverInitializedNames in AssignmentPatterns.
I seem to have caused a regression in `let []`, which now seems to parse as
a
MemberExpression rather than a declaration. I originally published the diff
to
figure out what caused that, and nothing really jumps out as having caused
it.
There's another regression for CoverInitializedName in binding patterns (at
least in arrow function parameters), so currently a lot of test failures are
about that.
Probably need to write up a design doc to really figure out how this is
going to
work.
As far as I can see, none of the other vendors have figured out a way to
accept
CoverInitializedName in ObjectAssignmentPattern, but reject it in
ObjectLiterals, so for the time being I'm just putting that on hold. It's
difficult to get that one working.
Description:
WIP parse destructuring assignment
Please review this at https://codereview.chromium.org/1301523004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+459, -36 lines):
M src/ast.h
M src/expression-classifier.h
M src/messages.h
M src/parser.h
M src/parser.cc
M src/preparser.h
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
