I don't remember for sure, probably due to some previous projects.
I've got
zsh/3 758 % readlink -f $(which cpplint.py)
/home/build/nonconf/google3/devtools/cpplint/cpplint.py
And some warnings I got seems to be google3-specific:
zsh/3 575 % ./tools/presubmit.py
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc:30:
Found
C system header after C++ system header. Should be: d8-readline.h, c
system, c++
system, other. [build/include_order] [4]
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc:31:
Found
C system header after C++ system header. Should be: d8-readline.h, c
system, c++
system, other. [build/include_order] [4]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc
/usr/local/google/homedirs/antonm/chromium/src/v8/samples/lineprocessor.cc:155:
Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated).
[runtime/deprecated_fn] [1]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/samples/lineprocessor.cc
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3895:
Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated).
[runtime/deprecated_fn] [1]
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3908:
Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated).
[runtime/deprecated_fn] [1]
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3922:
Consider using [safe_]strto32/64(...) instead of strtol(...) (deprecated).
[runtime/deprecated_fn] [1]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc
Total errors found: 6
May you tell me where your cpplint.py resides?
And thanks a lot for review.
On 2010/02/10 08:22:29, Søren Gjesse wrote:
LGTM
How can it be that you are using a different cpplint?
http://codereview.chromium.org/593014
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
