Thanks a lot for comments, Mads. May you have another look?
http://codereview.chromium.org/598020/diff/1/3 File src/accessors.cc (right): http://codereview.chromium.org/598020/diff/1/3#newcode651 src/accessors.cc:651: Handle<Object> handle(value); On 2010/02/10 08:00:46, Mads Ager wrote:
Add a HandleScope to this method to make sure this handle does not
leak to an
outer handle scope.
Done. http://codereview.chromium.org/598020/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/598020/diff/1/4#newcode2041 src/api.cc:2041: return !self->SetPrototype(value_obj, skip_hidden_prototypes)->IsFailure(); On 2010/02/10 08:00:46, Mads Ager wrote:
The failure return is for exceptions right? We should create a handle
based
version of SetPrototype in handles.cc which calls the one which does
not use
handles and returns an empty handle in case of exceptions. Then we
need to use
the exception handling macros to make sure that we correctly
reschedule
exceptions. Have a look at how that is handled in Set including
SetProperty in
handles.cc.
Done. http://codereview.chromium.org/598020 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
