Looking good, just comments about the new RawMachineAssembler::CallJS ...
https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-assembler.cc#newcode225
src/compiler/interpreter-assembler.cc:225: return CallJSBuiltin(builtin,
receiver, args, 1);
nit: Shouldn't the following do the trick ...
return CallJSBuiltin(builtin, receiver, &arg1, 1);
https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-assembler.cc
File src/compiler/raw-machine-assembler.cc (right):
https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-assembler.cc#newcode146
src/compiler/raw-machine-assembler.cc:146: buffer[index++] =
graph()->start();
Please don't add effect and control inputs to the call in the raw
machine assembler.
https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-assembler.cc#newcode148
src/compiler/raw-machine-assembler.cc:148: CallDescriptor* descriptor =
Linkage::GetJSCallDescriptor(
Would it be possible to just use RawMachineAssembler::CallN instead and
move computation of the call-descriptor to the caller (i.e. into
InterpreterAssembler) instead?
https://codereview.chromium.org/1300813005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
