LGTM! (Got to love a change that removes so much code!)
http://codereview.chromium.org/594009/diff/1/12 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/594009/diff/1/12#newcode1254 src/arm/macro-assembler-arm.cc:1254: ldr(r1, FieldMemOperand(target, builtins_offset)); Seems like you might as well just use r1 throughout instead of having a hidden scratch register here. http://codereview.chromium.org/594009/diff/1/12#newcode1257 src/arm/macro-assembler-arm.cc:1257: ldr(target, FieldMemOperand(target, SharedFunctionInfo::kCodeOffset)); A chain of 5 dependent loads! If this turns out to be slow we should consider putting the builtins array in the root array instead of accessing it through the context. Since you showed it's no slower on Intel perhaps it doesn't matter. http://codereview.chromium.org/594009 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
