LGTM. As discussed offline: I am fine with landing this as it is to unblock
interpreter work. We should just keep the alternative ideas about context
chain
access in mind. This might mean that we'd potentially remove this parameter
again if we decide to take an alternative approach.
https://codereview.chromium.org/1294133004/diff/20001/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):
https://codereview.chromium.org/1294133004/diff/20001/src/compiler/linkage.cc#newcode416
src/compiler/linkage.cc:416: #if defined(V8_TARGET_ARCH_IA32)
Just for posterity: Not a huge fan of this #ifdef here, but let's keep
it like it is and not overly abstract is for now, because it might
change in the future anyways.
https://codereview.chromium.org/1294133004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
