On 2015/08/20 11:39:17, Hannes Payer wrote:
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h File test/cctest/cctest.h (right):
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h#newcode559
test/cctest/cctest.h:559: bool complete = true) {
On 2015/08/20 11:14:39, Michael Lippautz wrote:
> nit: naming
Done.
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/test-heap.cc#newcode4661
test/cctest/test-heap.cc:4661: FLAG_manual_evacuation_candidates_selection =true; On 2015/08/20 11:14:39, Michael Lippautz wrote: > nit: Can we set this before VM initialization?
Done.
still lgtm but this seems risky https://codereview.chromium.org/1296713007/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
