Reviewers: ,
Message:
Hannes: The change we talked about. This is pre-work for fixing
chromium:520607.
Benedikt and Michi: Please check the approach for using private methods in a
cctest. It's similar to what gtest does without the need to friend every
test
(because it lives in a separate class). The drawback is the additional
macro on
top of heap-test.cc to get the declarations. The approach is also purely
local
to heap testing right now.
Michi: This would allow us to get rid of the protected-for-testing
declarations
in Heap and the TestHeap class in cctest.h
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode2341
src/heap/heap.h:2341: friend class IncrementalMarking;
Needed because we still have callers using incremental marking directly.
(see below)
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc#newcode490
src/heap/incremental-marking.cc:490: StartMarking();
Let's not reset the flags after kicking off incremental marking.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.h
File src/heap/incremental-marking.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.h#newcode84
src/heap/incremental-marking.h:84: void Start(int flags,
We should avoid calling into incremental marking directly. Let's do this
in another CL.
Description:
[heap] Cleanup and fix GC flags
GC flags are now part of the {Heap} and should be respected by all
sub-components.
Also add a infrastructure to write tests accessing private methods.
BUG=
Please review this at https://codereview.chromium.org/1301183002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+107, -53 lines):
M src/heap/heap.h
M src/heap/heap.cc
M src/heap/incremental-marking.h
M src/heap/incremental-marking.cc
M src/heap/mark-compact.h
M src/heap/mark-compact.cc
M src/heap/mark-compact-inl.h
M test/cctest/test-debug.cc
M test/cctest/test-heap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
