On 2015/08/20 12:50:12, rossberg wrote:
LGTM

It's sad that this makes the use of private symbols unmodular. But I guess
uniformity wins...

The upside is that we would share private symbols across different native
contexts instead of allocating new ones. This saves us from ICs going
polymorphic.



https://codereview.chromium.org/1293493004/diff/1/src/array-iterator.js
File src/array-iterator.js (right):


https://codereview.chromium.org/1293493004/diff/1/src/array-iterator.js#newcode16
src/array-iterator.js:16: var ArrayIterationKindSymbol =
I don't feel too strongly, but don't we typically use capitalised names for
functions only?



https://codereview.chromium.org/1293493004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to