Reviewers: Jarin, dehrenberg, bbudge,
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js#newcode339
src/harmony-simd.js:339: }
On 2015/08/20 18:23:34, bbudge wrote:
You should be able to use the V8 macro system on these to reduce
duplication.
There are examples in this file, above.
Done.
https://codereview.chromium.org/1302133002/diff/1/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1302133002/diff/1/src/messages.h#newcode268
src/messages.h:268: T(InvalidTypedArrayIndex, "The value of Index is
invalid") \
On 2015/08/20 18:23:34, bbudge wrote:
You should add a test in test/mjsunit/messages.js (search for 'simd'
for an
example.) I noticed there is no test for the message on line above
though.
Looks like I probably should not have added this to begin with - changed
to asserts and removed this.
https://codereview.chromium.org/1302133002/diff/1/src/runtime/runtime-simd.cc
File src/runtime/runtime-simd.cc (right):
https://codereview.chromium.org/1302133002/diff/1/src/runtime/runtime-simd.cc#newcode830
src/runtime/runtime-simd.cc:830: FUNCTION(Int8x16, int8_t, 16)
On 2015/08/20 18:23:34, bbudge wrote:
You'll have to partition these, since only the 4-lane types have LoadN
/ StoreN.
Done.
https://codereview.chromium.org/1302133002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/1302133002/diff/1/src/runtime/runtime.h#newcode693
src/runtime/runtime.h:693: F(Int16x8Load3, 2, 1)
\
On 2015/08/20 18:23:34, bbudge wrote:
The spec no longer defines the LoadN / StoreN functions on types with
8 or 16
lanes, so you can remove them here and below.
Done.
Description:
V8: Add SIMD functions for Phase 1.
Float32x4, Int32x4, Int16x8, Int8x16:
load, load1, load2, load3
BUG=v8:4124
Please review this at https://codereview.chromium.org/1302133002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+126, -0 lines):
M src/harmony-simd.js
M src/runtime/runtime.h
M src/runtime/runtime-simd.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
