Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values.
port f4c079d450a5990639b295d40a3d1663d70412d6 (r30107).
This is the appendix of 458dfe3b943edb3238917edfe9e2dde326cd1adb which
misses
one modified file.
original commit message:
There's no need to have one InstanceType per SIMD primitive type (this
will not scale long-term). Also reduce the amount of code duplication
and make it more robust wrt adding new SIMD types.
BUG=
Please review this at https://codereview.chromium.org/1304963003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+11, -39 lines):
M src/x87/lithium-codegen-x87.cc
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
012efd0ca8ab70fb3aa68e6e96ba710ec3b494ab..fbb2a99e39669cc0c733a564ae0b7c3f826d89d4
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -2439,12 +2439,8 @@ void LCodeGen::DoBranch(LBranch* instr) {
if (expected.Contains(ToBooleanStub::SIMD_VALUE)) {
// SIMD value -> true.
- Label not_simd;
- __ CmpInstanceType(map, FIRST_SIMD_VALUE_TYPE);
- __ j(less, ¬_simd, Label::kNear);
- __ CmpInstanceType(map, LAST_SIMD_VALUE_TYPE);
- __ j(less_equal, instr->TrueLabel(chunk_));
- __ bind(¬_simd);
+ __ CmpInstanceType(map, SIMD128_VALUE_TYPE);
+ __ j(equal, instr->TrueLabel(chunk_));
}
if (expected.Contains(ToBooleanStub::HEAP_NUMBER)) {
@@ -6150,40 +6146,16 @@ Condition
LCodeGen::EmitTypeofIs(LTypeofIsAndBranch* instr, Register input) {
1 << Map::kIsUndetectable);
final_branch_condition = zero;
- } else if (String::Equals(type_name, factory()->float32x4_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, FLOAT32X4_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->int32x4_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, INT32X4_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->bool32x4_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, BOOL32X4_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->int16x8_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, INT16X8_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->bool16x8_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, BOOL16X8_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->int8x16_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, INT8X16_TYPE, input);
- final_branch_condition = equal;
-
- } else if (String::Equals(type_name, factory()->bool8x16_string())) {
- __ JumpIfSmi(input, false_label, false_distance);
- __ CmpObjectType(input, BOOL8X16_TYPE, input);
+// clang-format off
+#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
+ } else if (String::Equals(type_name, factory()->type##_string())) { \
+ __ JumpIfSmi(input, false_label, false_distance); \
+ __ cmp(FieldOperand(input, HeapObject::kMapOffset), \
+ factory()->type##_map()); \
final_branch_condition = equal;
+ SIMD128_TYPES(SIMD128_TYPE)
+#undef SIMD128_TYPE
+ // clang-format on
} else {
__ jmp(false_label, false_distance);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
