Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [turbofan] Support unboxed float and double stack parameters and add
tests.
port 0492bb3291c838d7e11261abc32af58bed58bcf0 (r30203).
original commit message:
BUG=
Please review this at https://codereview.chromium.org/1306833002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -1 lines):
M src/compiler/x87/code-generator-x87.cc
M src/compiler/x87/instruction-selector-x87.cc
Index: src/compiler/x87/code-generator-x87.cc
diff --git a/src/compiler/x87/code-generator-x87.cc
b/src/compiler/x87/code-generator-x87.cc
index
c3e999bcbffc40b1fb12c5c10f4ba20e4498e7b5..391cdcadafdbc01f5923fb84fa21fab0503a70ed
100644
--- a/src/compiler/x87/code-generator-x87.cc
+++ b/src/compiler/x87/code-generator-x87.cc
@@ -1104,7 +1104,29 @@ void
CodeGenerator::AssembleArchInstruction(Instruction* instr) {
break;
}
case kX87Push:
- if (HasImmediateInput(instr, 0)) {
+ if (instr->InputAt(0)->IsDoubleRegister()) {
+ auto allocated = AllocatedOperand::cast(*instr->InputAt(0));
+ if (allocated.machine_type() == kRepFloat32) {
+ __ sub(esp, Immediate(kDoubleSize));
+ __ fst_s(Operand(esp, 0));
+ } else {
+ DCHECK(allocated.machine_type() == kRepFloat64);
+ __ sub(esp, Immediate(kDoubleSize));
+ __ fst_d(Operand(esp, 0));
+ }
+ } else if (instr->InputAt(0)->IsDoubleStackSlot()) {
+ auto allocated = AllocatedOperand::cast(*instr->InputAt(0));
+ if (allocated.machine_type() == kRepFloat32) {
+ __ sub(esp, Immediate(kDoubleSize));
+ __ fld_s(i.InputOperand(0));
+ __ fstp_s(MemOperand(esp, 0));
+ } else {
+ DCHECK(allocated.machine_type() == kRepFloat64);
+ __ sub(esp, Immediate(kDoubleSize));
+ __ fld_d(i.InputOperand(0));
+ __ fstp_d(MemOperand(esp, 0));
+ }
+ } else if (HasImmediateInput(instr, 0)) {
__ push(i.InputImmediate(0));
} else {
__ push(i.InputOperand(0));
Index: src/compiler/x87/instruction-selector-x87.cc
diff --git a/src/compiler/x87/instruction-selector-x87.cc
b/src/compiler/x87/instruction-selector-x87.cc
index
04a7d5a09af40ebb8787c354b7e702ceaee64654..c1c1e5339becb7d07ec2558d4f84be870452f811
100644
--- a/src/compiler/x87/instruction-selector-x87.cc
+++ b/src/compiler/x87/instruction-selector-x87.cc
@@ -853,6 +853,7 @@ void InstructionSelector::VisitCall(Node* node,
BasicBlock* handler) {
// Push any stack arguments.
for (Node* input : base::Reversed(buffer.pushed_nodes)) {
// TODO(titzer): handle pushing double parameters.
+ if (input == nullptr) continue;
InstructionOperand value =
g.CanBeImmediate(input)
? g.UseImmediate(input)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
