Reviewers: Weiliang,
Message:
PTAL
Description:
X87: VectorICs: New interface descriptor for vector transitioning stores.
port cd35155918f8f1a081a208721a878deba00a252b (r30284).
original commit message:
BUG=
Please review this at https://codereview.chromium.org/1303223002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+17, -12 lines):
M src/x87/interface-descriptors-x87.cc
Index: src/x87/interface-descriptors-x87.cc
diff --git a/src/x87/interface-descriptors-x87.cc
b/src/x87/interface-descriptors-x87.cc
index
204e0bf6194808b33d37cf83751f5b9ac3a13146..a96aeef40ad762ae64ad36303bfa76ba46fce291
100644
--- a/src/x87/interface-descriptors-x87.cc
+++ b/src/x87/interface-descriptors-x87.cc
@@ -30,11 +30,22 @@ const Register
VectorStoreICTrampolineDescriptor::SlotRegister() { return edi; }
const Register VectorStoreICDescriptor::VectorRegister() { return ebx; }
-const Register StoreTransitionDescriptor::MapRegister() {
- return FLAG_vector_stores ? no_reg : ebx;
+const Register VectorStoreTransitionDescriptor::SlotRegister() {
+ return no_reg;
}
+const Register VectorStoreTransitionDescriptor::VectorRegister() {
+ return no_reg;
+}
+
+
+const Register VectorStoreTransitionDescriptor::MapRegister() { return
no_reg; }
+
+
+const Register StoreTransitionDescriptor::MapRegister() { return ebx; }
+
+
const Register LoadGlobalViaContextDescriptor::SlotRegister() { return
ebx; }
@@ -65,17 +76,11 @@ const Register
GrowArrayElementsDescriptor::ObjectRegister() { return eax; }
const Register GrowArrayElementsDescriptor::KeyRegister() { return ebx; }
-void StoreTransitionDescriptor::InitializePlatformSpecific(
+void VectorStoreTransitionDescriptor::InitializePlatformSpecific(
CallInterfaceDescriptorData* data) {
- Register registers[] = {ReceiverRegister(), NameRegister(),
ValueRegister(),
- MapRegister()};
-
- // When FLAG_vector_stores is true, we want to pass the map register on
the
- // stack instead of in a register.
- DCHECK(FLAG_vector_stores || !MapRegister().is(no_reg));
-
- int register_count = FLAG_vector_stores ? 3 : 4;
- data->InitializePlatformSpecific(register_count, registers);
+ Register registers[] = {ReceiverRegister(), NameRegister(),
ValueRegister()};
+ // The other three parameters are on the stack in ia32.
+ data->InitializePlatformSpecific(arraysize(registers), registers);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
