Reviewers: Hannes Payer,
Message:
Impact on Havlak:
d8 benchmarks/common/javascript/bench.js
benchmarks/Havlak/javascript/Havlak.js
--predictable --move-object-start ; done | awk -e '{ sum+=$2 } END { print
sum/NR; }'
1399.88
d8 benchmarks/common/javascript/bench.js
benchmarks/Havlak/javascript/Havlak.js
--predictable --nomove-object-start ; done | awk -e '{ sum+=$2 } END { print
sum/NR; }'
1403.58
Description:
[heap] Disable moving object starts aka left trimming
BUG=
Please review this at https://codereview.chromium.org/1301963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -0 lines):
M src/flag-definitions.h
M src/heap/heap.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
88ba0e402f314e6f2bc45e6680ea40b38c479835..dab522e3dc56cf93018b2388ef323c2635336c3c
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -674,6 +674,7 @@ DEFINE_IMPLICATION(trace_detached_contexts,
track_detached_contexts)
#ifdef VERIFY_HEAP
DEFINE_BOOL(verify_heap, false, "verify heap pointers before and after GC")
#endif
+DEFINE_BOOL(move_object_start, false, "enable moving of object starts")
// counters.cc
DEFINE_INT(histogram_interval, 600000,
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
234bc9f563a14d148cc19967d902fb7cc1c4ff8e..864785729e0b899b1aa1cba7aa4e5722280c8ef2
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -3700,6 +3700,8 @@ void Heap::CreateFillerObjectAt(Address addr, int
size) {
bool Heap::CanMoveObjectStart(HeapObject* object) {
+ if (!FLAG_move_object_start) return false;
+
Address address = object->address();
if (lo_space()->Contains(object)) return false;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
