lgtm

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc#newcode6664
src/heap/heap.cc:6664:
-line

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.h#newcode1686
src/heap/heap.h:1686: class UnmapFreeMemoryTask;
Move to the top of the private section.

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1303263002/diff/20001/src/heap/mark-compact.cc#newcode529
src/heap/mark-compact.cc:529:
heap()->WaitUntilUnmappingOfFreeChunksCompleted();
Just a note: This is dependent on "sweeping_in_progress()". Maybe we can
think of a way to make this less fragile.

https://codereview.chromium.org/1303263002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to