Reviewers: mvstanton, Yang,
Message:
Yang: Not sure when Michael will be back, could you PTAL in the meantime?
Thanks!
https://codereview.chromium.org/1314623002/diff/20001/src/arm/simulator-arm.h
File src/arm/simulator-arm.h (left):
https://codereview.chromium.org/1314623002/diff/20001/src/arm/simulator-arm.h#oldcode444
src/arm/simulator-arm.h:444: // This is unlikely to be an issue in
practice, though it might cause testing
You claim this to unlikely be an issue in practice. The subsequent
explosions on ClusterFuzz over the last week proof that to be lie. :)
Description:
Make Simulator respect C stack limits as well.
The simulator uses a separate JS stack, exhaustion of the C stack
however is not caught by JS limit checks. This change now lowers the
limit of the JS stack accordingly on function calls.
[email protected]
BUG=chromium:522380
TEST=mjsunit/regress/regress-crbug-522380
LOG=n
Please review this at https://codereview.chromium.org/1314623002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+101, -49 lines):
M src/arm/simulator-arm.h
M src/arm/simulator-arm.cc
M src/arm64/simulator-arm64.h
M src/arm64/simulator-arm64.cc
M src/execution.h
M src/execution.cc
M src/mips/simulator-mips.h
M src/mips/simulator-mips.cc
M src/mips64/simulator-mips64.h
M src/mips64/simulator-mips64.cc
A + test/mjsunit/regress/regress-crbug-522380.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
