Thanks.
https://codereview.chromium.org/1310253002/diff/1/src/json-parser.h
File src/json-parser.h (right):
https://codereview.chromium.org/1310253002/diff/1/src/json-parser.h#newcode267
src/json-parser.h:267: ExecutionAccess access(isolate_);
On 2015/08/24 14:50:43, Yang wrote:
On 2015/08/24 14:40:06, Michael Starzinger wrote:
> Aehm, are we sure that acquiring the lock here is correct? This will
hold on
to
> the lock while the GC is active. This looks majorly scary to me. The
lock
should
> only be needed to do the interrupt checking, which is done inside
> StackGuard::CheckAndClearInterrupt where the lock is acquired
explicitly.
yup that looks both somewhat wrong and also unnecessary. though i dont
think
this will lead to a dead lock. we dont expect an interrupt to trigger
during gc.
Acknowledged. I discussed this briefly with Hannes as well. We think
that this tried to fix a missing fence between the limit read in line
266 and the potential limit reset in line 269, but are not sure yet.
Anyways, I am not going to touch it in this CL, to keep this CL a pure
refactoring cleanup. But it still scares me.
https://codereview.chromium.org/1310253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
