lgtm with test nits
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc#newcode3750
test/cctest/test-parsing.cc:3750: // "({a} = {}) => {}",
Perhaps add a pattern for ({a=42})=>{} too? Unless I am misreading the
grammar of course. Same thing for array patterns with initializers. I
don't remember what the state of the implementation is though.
AFAIU default parameters should work now so we probably also need
functional tests, i.e. tests that also invoke the arrow function.
https://codereview.chromium.org/1314543005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
