Comment #1 on issue 4389 by [email protected]: Crankshaft optimization of inlined Math operators generates wrong code
https://code.google.com/p/v8/issues/detail?id=4389#c1

The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39

commit fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39
Author: bmeurer <[email protected]>
Date: Tue Aug 25 06:24:40 2015

[crankshaft] DCE must not eliminate (observable) math operations.

The HUnaryMathOperation cannot be eliminated in general, because the
spec requires a ToNumber conversion on the input, which is observable
of course.

BUG=v8:4389
LOG=y

Review URL: https://codereview.chromium.org/1307413003

Cr-Commit-Position: refs/heads/master@{#30343}

[modify] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/src/hydrogen-instructions.h [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-1.js [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-2.js [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-3.js [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-4.js [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-5.js [add] http://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39/test/mjsunit/compiler/regress-4389-6.js


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to