https://codereview.chromium.org/1311163002/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1311163002/diff/1/src/scopes.h#newcode133
src/scopes.h:133: bool is_optional, bool is_rest, bool* is_duplicate);
On 2015/08/24 17:51:00, adamk wrote:
Two bools in a row suggests to me that an enum would be better.
Given that is_optional and is_rest are mutually exclusive, they could
even be
part of the same enum, e.g.:
enum class ParameterType {
kNormal,
kOptional,
kRest
};
I realize that there's only a single caller, though, so another option
would be
to simply name the is_optional variable passed in the caller.
Named it at call site.
https://codereview.chromium.org/1311163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
