Reviewers: haraken,
Message:
Is the blink counterpart ready?
Description:
[heap] Report proper GC type in prologue/eplilogue callbacks.
Followup to https://codereview.chromium.org/1288683005
BUG=chromium:521946
Please review this at https://codereview.chromium.org/1313023002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -6 lines):
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
f19e52156d83ab8538bf7283ae5b01f2a00acabe..ec3837cfbec09c4ce8f52b2e9a7530d8203863c4
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -768,9 +768,7 @@ void Heap::OverApproximateWeakClosure(const char*
gc_reason) {
GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);
VMState<EXTERNAL> state(isolate_);
HandleScope handle_scope(isolate_);
- // TODO(mlippautz): Report kGCTypeIncremental once blink updates its
- // filtering.
- CallGCPrologueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags);
+ CallGCPrologueCallbacks(kGCTypeIncrementalMarking,
kNoGCCallbackFlags);
}
}
incremental_marking()->MarkObjectGroups();
@@ -781,9 +779,7 @@ void Heap::OverApproximateWeakClosure(const char*
gc_reason) {
GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);
VMState<EXTERNAL> state(isolate_);
HandleScope handle_scope(isolate_);
- // TODO(mlippautz): Report kGCTypeIncremental once blink updates its
- // filtering.
- CallGCEpilogueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags);
+ CallGCEpilogueCallbacks(kGCTypeIncrementalMarking,
kNoGCCallbackFlags);
}
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
