https://codereview.chromium.org/1315823002/diff/20001/src/interpreter/bytecode-generator.cc
File src/interpreter/bytecode-generator.cc (right):
https://codereview.chromium.org/1315823002/diff/20001/src/interpreter/bytecode-generator.cc#newcode339
src/interpreter/bytecode-generator.cc:339: UNIMPLEMENTED();
Nit: This should probably be UNREACHABLE (same for Spread)
https://codereview.chromium.org/1315823002/diff/20001/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):
https://codereview.chromium.org/1315823002/diff/20001/src/pattern-rewriter.cc#newcode367
src/pattern-rewriter.cc:367: // TODO(dslomov): implement.
While you're here, can you change this to UNREACHABLE?
https://codereview.chromium.org/1315823002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1315823002/diff/20001/src/preparser.h#newcode2279
src/preparser.h:2279: } else if (allow_harmony_rest_parameters() &&
Check(Token::ELLIPSIS)) {
I wonder, does rest actually need special treatment here? Can't it
simply be parsed as spread in the else case below, and later be
rewritten?
https://codereview.chromium.org/1315823002/diff/20001/src/prettyprinter.cc
File src/prettyprinter.cc (right):
https://codereview.chromium.org/1315823002/diff/20001/src/prettyprinter.cc#newcode854
src/prettyprinter.cc:854: Print("<empty-parentheses>");
I'd print "()" here.
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
