Reviewers: Hannes Payer,

Message:
More invasive than planned. The idea is that as soon as you call the GC with
non-default parameters you better have a reason why you do so.

The rest of the change is properly typing GC flags and making sure that the
both, the GCFlags and GCCallbackFlags, are properly set and reset.

Description:
[heap] More flag cleanup.

* GC's flags are now proper flags and not int.
* Callback flags are not threaded through but only set once like gc flags
* Callers of methods that trigger GCs need to pass a reason when not using
  the default parameters.

BUG=

Please review this at https://codereview.chromium.org/1314863003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+160, -145 lines):
  M src/api.cc
  M src/debug/debug.cc
  M src/extensions/statistics-extension.cc
  M src/heap-snapshot-generator.cc
  M src/heap/heap.h
  M src/heap/heap.cc
  M src/heap/heap-inl.h
  M src/heap/memory-reducer.cc
  M src/log.cc
  M src/runtime/runtime-debug.cc
  M test/cctest/test-api.cc
  M test/cctest/test-debug.cc
  M test/cctest/test-heap.cc
  M test/cctest/test-log.cc
  M test/cctest/test-mementos.cc
  M test/cctest/test-object-observe.cc
  M test/cctest/test-weakmaps.cc
  M test/cctest/test-weaksets.cc


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to