Reviewers: adamk,
Description:
Unship TypedArray.map method
The TypedArray.map method breaks a particular Chrome app, which
conditionally
monkey-patches in an unrelated function with the same name, but only if that
property does not exist. The developer already has a fix, but it is not
deployed to all contexts yet. For now, this patch unships the TypedArray.map
method, but the longer-term solution will be to work with the developer to
deploy the fix to the Turbulenz game engine.
BUG=chromium:524392
LOG=Y
R=adamk
Please review this at https://codereview.chromium.org/1308713005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -1 lines):
M src/harmony-typedarray.js
M test/mjsunit/mjsunit.status
Index: src/harmony-typedarray.js
diff --git a/src/harmony-typedarray.js b/src/harmony-typedarray.js
index
cd220dae832e2e1dfdc9480b979951e53f2c27b6..900669806467c97fc2ae815094c74f2b7d98e049
100644
--- a/src/harmony-typedarray.js
+++ b/src/harmony-typedarray.js
@@ -398,7 +398,8 @@ macro EXTEND_TYPED_ARRAY(NAME)
"join", TypedArrayJoin,
"lastIndexOf", TypedArrayLastIndexOf,
"forEach", TypedArrayForEach,
- "map", TypedArrayMap,
+ // BUG(chromium:524392): Ship TypedArray.map once it doesn't break the
web
+ // "map", TypedArrayMap,
"reduce", TypedArrayReduce,
"reduceRight", TypedArrayReduceRight,
"reverse", TypedArrayReverse,
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
8e199946d125b8f1a76589b2f064a9c3677404df..af4ccfb8b743dbef1d176b7064e3755f60a790d9
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -252,6 +252,10 @@
# BUG(chromium:508074). Remove this once the issue is fixed.
'harmony/arrow-rest-params': [PASS, NO_VARIANTS],
'harmony/rest-params': [PASS, ['no_snap == True', NO_VARIANTS]],
+
+
+ # BUG(chromium:524392): Ship TypedArray.map once it doesn't break the web
+ 'es6/typedarray-iteration': [FAIL],
}], # ALWAYS
['novfp3 == True', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
