lgtm
https://codereview.chromium.org/1303013007/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1303013007/diff/1/src/parser.cc#newcode4390
src/parser.cc:4390: CheckConflictingVarDeclarations(param_scope,
CHECK_OK);
Not new in this patch, but I'm wondering why we check this when it's a
new declaration scope that's introduced. I don't see how you could come
up with a conflict now, but with do-expressions I could imagine it, and
that var declaration should just not be visible anywhere after the
parameters are evaluated.
https://codereview.chromium.org/1303013007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
