Comment #4 on issue 4388 by [email protected]: TurboFan AST graph
builder is missing a phi in switch statements
https://code.google.com/p/v8/issues/detail?id=4388
I found your bug. It is s/value->opcode/current->opcode/ in the following
snippet in BuildVariableAssignment. Please also appreciate the comment in
this snippet that now no longer hold. The same bug seems to be in the {mode
== CONST && op != Token::INIT_CONST} case, which makes our test coverage
look pretty bad. :(
} else if (mode == LET && op != Token::INIT_LET) {
// Perform an initialization check for let declared variables.
// Also note that the dynamic hole-check is only done to ensure that
// this does not break in the presence of do-expressions within the
// temporal dead zone of a let declared variable.
Node* current = environment()->Lookup(variable);
if (current->op() == the_hole->op()) {
value = BuildThrowReferenceError(variable, bailout_id);
} else if (value->opcode() == IrOpcode::kPhi) {
value = BuildHoleCheckThenThrow(current, variable, value,
bailout_id);
}
}
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
