On 2015/08/25 04:53:48, Benedikt Meurer wrote:
Hey Adam,
I'm currently working on implementing ToPrimitive for ES6, in a way that
we
can
have %_ToPrimitive, %_ToNumber and %_ToString (with proper code stubs and
also
proper support for those within the runtime without resorting to
Execution::ToNumber and friends). Once this is done, it should be easy to
add
%_ToInteger and %_ToLength on top and then we can remove the helpers from
runtime.js completely.
But that'll take time, so landing your patch still makes sense to make
progress
now. I'm not sure about the test failures, but I'd say the patch is LGTM.
Thanks for the background, and I look forward to the future you describe.
In the meantime, most of the failures were due to a missing NaN check (which
I've added). But I'm getting an odd failure in the
Reflect.apply/Reflect.construct tests (looks like it might be an infinite
recursion); still investigating.
https://codereview.chromium.org/1314493005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
