LGTM with comments.
On a related note: Please make sure that your CL description lines fit
within 80
characters.
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.cc#newcode2027
src/compiler/register-allocator.cc:2027: auto range =
data()->GetOrCreateLiveRangeFor(operand_index);
Nit: please deautofy this.
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.h#newcode285
src/compiler/register-allocator.h:285: TopLevelLiveRange* TopLevel() {
return parent_; }
parent_ should be renamed to toplevel_ (or top_level_ to keep the naming
in sync).
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.h#newcode289
src/compiler/register-allocator.h:289: return
reinterpret_cast<LiveRange*>(parent_) == this;
The reinterpret_cast is unnecessary (and dangerous) here. Just delay the
definition of this function until after the definition of
TopLevelLiveRange and everything will be fine.
https://codereview.chromium.org/1311983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
