Reviewers: Yang,
Message:
Hi Yang,
Here is the CL we discussed. Validates/protects that the handlers have the
same
store mode as the IC extra state bits.
Description:
Vector ICs: Ensure KeyedAccessStore mode is encoded in all handlers.
For vector-based keyed store ics, we need to know the current
KeyedAccessStore mode on ic MISS, and to produce optimized code.
We can't store this mode, which can change on any MISS in the IC
without patching. Therefore, this CL makes sure that the information is
redundantly available in the handlers embedded in the IC. This way,
when --vector-stores is turned on, we'll be able to extract that
information from the vector which maintains a list of these handlers.
BUG=
Please review this at https://codereview.chromium.org/1312693004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+88, -30 lines):
M src/ast.h
M src/code-stubs.h
M src/ic/ic.h
M src/ic/ic.cc
M src/ic/ic-compiler.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
