lgtm

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc#newcode956
src/snapshot/serialize.cc:956: int id = source_.GetInt();
                             \
On 2015/08/25 15:19:39, Michael Starzinger wrote:
On 2015/08/25 15:13:25, Michael Lippautz wrote:
> I would say use const here but since all the other cases also don't
specify it
> we should probably leave it for uniformity.

Acknowledged. I'll leave the decision up to Yang, since it's deep
inside the
Deserializer.

I'm fine with either.

https://codereview.chromium.org/1312763006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to