LGTM.
https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):
https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc#newcode1032
src/arm64/builtins-arm64.cc:1032: __ Drop(x1);
Not sure but isn't the ARM64 macro assembler expecting "count" instead
of size here when a register is passed in? Shouldn't this be "Drop(x1,
1)" instead?
https://codereview.chromium.org/1303403004/diff/140001/src/frames.h
File src/frames.h (right):
https://codereview.chromium.org/1303403004/diff/140001/src/frames.h#newcode183
src/frames.h:183:
nit: Two empty newlines.
https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h#newcode4063
src/objects-inl.h:4063: return READ_INT_FIELD(this,
kParameterSizeOffset) >> kPointerSizeLog2;
Can we leave a short one-liner comment here that the "count" is stored
as a "size" so that generated code can use it directly?
Also is this "trick" really worth it? Don't most of the architectures
should have instructions with the appropriate scalling factors? Not an
expert on this, so I don't mind either way.
https://codereview.chromium.org/1303403004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
