On 2015/08/26 14:18:52, Yang wrote:
On 2015/08/26 14:16:42, Michael Starzinger wrote:
> LGTM modulo architecture ports. Didn't look at interpreter though.
>
>
https://codereview.chromium.org/1316943002/diff/1/src/compiler/ast-graph-builder.cc
> File src/compiler/ast-graph-builder.cc (right):
>
>
https://codereview.chromium.org/1316943002/diff/1/src/compiler/ast-graph-builder.cc#newcode2544
> src/compiler/ast-graph-builder.cc:2544:
> nit: Let's drop this empty newline, the pushes belong to the comment
above.
>
> https://codereview.chromium.org/1316943002/diff/1/src/contexts.h
> File src/contexts.h (right):
>
>
https://codereview.chromium.org/1316943002/diff/1/src/contexts.h#newcode206
> src/contexts.h:206: NATIVE_CONTEXT_JS_BUILTINS(V)
> Is there a reason we are adding this to the
NATIVE_CONTEXT_IMPORTED_FIELDS
> instead of the NATIVE_CONTEXT_FIELDS below?
yes. Im using %InstallToContext in runtime.js to put them on the native
context,
and it does the name lookup for imported fields.
Hmm, we could add it to Context::ImportedFieldIndexForName explicitly to
avoid
surprises. WDYT? I am fine either way, just a suggestion.
https://codereview.chromium.org/1316943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
