Reviewers: Benedikt Meurer, dstence, joransiu, john.yan,
Description:
PPC: [compiler] Remove broken support for undetectable strings.
Port b62dbf1efdec68ae709b0e91d3b7c13171b720c9
Original commit message:
Support for undetectable strings was officially dropped in
https://codereview.chromium.org/916753002, but the compilers
weren't fixed properly.
[email protected], [email protected], [email protected],
[email protected]
BUG=
Please review this at https://codereview.chromium.org/1312473012/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -11 lines):
M src/full-codegen/ppc/full-codegen-ppc.cc
M src/ppc/lithium-codegen-ppc.cc
Index: src/full-codegen/ppc/full-codegen-ppc.cc
diff --git a/src/full-codegen/ppc/full-codegen-ppc.cc
b/src/full-codegen/ppc/full-codegen-ppc.cc
index
edcac11e3d368d4462a5afc555ee54bd6a47e5f9..ae6a2bd566590ac83c0a45ddf22478e17a6e77e4
100644
--- a/src/full-codegen/ppc/full-codegen-ppc.cc
+++ b/src/full-codegen/ppc/full-codegen-ppc.cc
@@ -4992,13 +4992,8 @@ void
FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
Split(eq, if_true, if_false, fall_through);
} else if (String::Equals(check, factory->string_string())) {
__ JumpIfSmi(r3, if_false);
- // Check for undetectable objects => false.
__ CompareObjectType(r3, r3, r4, FIRST_NONSTRING_TYPE);
- __ bge(if_false);
- __ lbz(r4, FieldMemOperand(r3, Map::kBitFieldOffset));
- STATIC_ASSERT((1 << Map::kIsUndetectable) < 0x8000);
- __ andi(r0, r4, Operand(1 << Map::kIsUndetectable));
- Split(eq, if_true, if_false, fall_through, cr0);
+ Split(lt, if_true, if_false, fall_through);
} else if (String::Equals(check, factory->symbol_string())) {
__ JumpIfSmi(r3, if_false);
__ CompareObjectType(r3, r3, r4, SYMBOL_TYPE);
Index: src/ppc/lithium-codegen-ppc.cc
diff --git a/src/ppc/lithium-codegen-ppc.cc b/src/ppc/lithium-codegen-ppc.cc
index
75023a2c415a11cfb0270dc8e78fb13d829fca6f..1e28f664458dfccc9352e91064204f8d9e50f371
100644
--- a/src/ppc/lithium-codegen-ppc.cc
+++ b/src/ppc/lithium-codegen-ppc.cc
@@ -5903,11 +5903,7 @@ Condition LCodeGen::EmitTypeofIs(Label* true_label,
Label* false_label,
} else if (String::Equals(type_name, factory->string_string())) {
__ JumpIfSmi(input, false_label);
__ CompareObjectType(input, scratch, no_reg, FIRST_NONSTRING_TYPE);
- __ bge(false_label);
- __ lbz(scratch, FieldMemOperand(scratch, Map::kBitFieldOffset));
- __ ExtractBit(r0, scratch, Map::kIsUndetectable);
- __ cmpi(r0, Operand::Zero());
- final_branch_condition = eq;
+ final_branch_condition = lt;
} else if (String::Equals(type_name, factory->symbol_string())) {
__ JumpIfSmi(input, false_label);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
