Reviewers: adamk, aperez, conradw, dehrenberg, wingo,
Message:
PTAL when time permits
This is the third try at this (following https://crrev.com/1168643005 and
https://crrev.com/1301523004. There is a lot of cleanup needed. This only
deals
with parsing, the desugaring is only a placeholder at the moment.
Description:
[es6] parse destructuring assignment
Attempt #3
This will cause pretty bad code load perf regressions. This may be
mitigated a bit with some cleanup and refactoring (not all of the changes
turned out to be necessary).
It is also quite likely that the test coverage does not cover every possible
combination of inputs, and may be missing some corner cases.
Some slightly unrelated changes include:
- Make Array element following rest parameter, or assignment to a rest
element
a syntax error
- Only report `...` as an unexpected token when parsing ArrayLiteral if both
`harmony_spread_arrays` and `harmony-destructuring` are disabled.
TODO:
- Delete unused changes / cleanup
- New flag for destructuring assignment, which implies destructuring
- Find cheaper ways of performing the various checks specific to reporting
pattern
errors.
BUG=v8:811
LOG=N
R=adamk, wingo, aperez, conradw, dehrenberg
Please review this at https://codereview.chromium.org/1309813007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+432, -15 lines):
M src/expression-classifier.h
M src/messages.h
M src/parser.h
M src/parser.cc
M src/preparser.h
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
